[libjxl] update to 0.8.0 #29171
Merged
[libjxl] update to 0.8.0 #29171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
quyykk
force-pushed
the
update-libjxl-0.8.0
branch
from
d44cd75 to
d568c3e
Compare
BillyONeal
approved these changes
Jan 25, 2023
| --- a/third_party/CMakeLists.txt | ||
| +++ b/third_party/CMakeLists.txt | ||
| @@ -45,36 +45,7 @@ else() | ||
| @@ -45,59 +45,7 @@ else() | ||
| endif() | ||
|
|
||
| # brotli |
There was a problem hiding this comment.
I'm going to merge this as is because it has already passed testing but in the future it might be a good idea to disable this block with an if(0) rather than deleting the whole content so that we aren't including so much of upstream's code in the registry.
There was a problem hiding this comment.
I was about to add a more detailed comment...
There was a problem hiding this comment.
Do you need this backed off?
There was a problem hiding this comment.
No, there is no regression. But I will check the port and its patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.