Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blend2d] Update to 2022-12-31 #28962

Merged
merged 2 commits into from
Jan 16, 2023
Merged

[blend2d] Update to 2022-12-31 #28962

merged 2 commits into from
Jan 16, 2023

Conversation

ZeeWanderer
Copy link
Contributor

@ZeeWanderer ZeeWanderer commented Jan 15, 2023

Describe the pull request

  • What does your PR fix?

Updates blend2d port to version 2022-12-31

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    arm64-windows, arm-uwp, and x64-uwp triplets are not supported. Triplet support has not changed since the last update.

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

ARM

Arm should work but it can't be compiled by MSVC

asmjit defines a macro

#define ASMJIT_INST_2x(NAME, ID, T0, T1) \ 
  inline Error NAME(const T0& o0, const T1& o1) { return _emitter()->_emitI(Inst::kId##ID, o0, o1); }

and uses it as follows

ASMJIT_INST_2x(mvn, Mvn, Gp, Gp)

but MSVC WinSDK has globally defined mvn macro

#define mvn(src) neon_not(src)

so the asmjit macro expands to

inline Error neon_not(const Gp& o0) { return _emitter()->_emitI(Inst::kIdMvn, o0, o1); }

instead of

inline Error mvn(const Gp& o0, const Gp& o1) { return _emitter()->_emitI(Inst::kIdMvn, o0, o1); }

a patch with a simple undef would work but this is an include file, so I am not really sure how to patch that

Seriously thou, a global 3-char macro without any underscores? Global marco for all ASIMD instructions without any underscores? That is not OK.

UWP

upw fails config with
config-x64-uwp-out.log
I don't know what needs to be done to support it.

@Cheney-W Cheney-W self-assigned this Jan 16, 2023
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jan 16, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 16, 2023
@ZeeWanderer
Copy link
Contributor Author

@vicroms vicroms merged commit 77a14f2 into microsoft:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants