Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Updates
blend2d
port to version2022-12-31
Which triplets are supported/not supported? Have you updated the CI baseline?
arm64-windows
,arm-uwp
, andx64-uwp
triplets are not supported. Triplet support has not changed since the last update.Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
ARM
Arm should work but it can't be compiled by
MSVC
asmjit defines a macro
and uses it as follows
ASMJIT_INST_2x(mvn, Mvn, Gp, Gp)
but MSVC WinSDK has globally defined
mvn
macroso the asmjit macro expands to
instead of
a patch with a simple
undef
would work but this is an include file, so I am not really sure how to patch thatSeriously thou, a global 3-char macro without any underscores? Global marco for all ASIMD instructions without any underscores? That is not OK.
UWP
upw fails config with
config-x64-uwp-out.log
I don't know what needs to be done to support it.