Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasm] Update to 2.16.01. #28950

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[nasm] Update to 2.16.01. #28950

merged 3 commits into from
Jan 20, 2023

Conversation

Sibras
Copy link
Contributor

@Sibras Sibras commented Jan 14, 2023

Updates 'vcpkg_find_acquire_program' to use latest nasm release.

@reitowo
Copy link
Contributor

reitowo commented Jan 14, 2023

Will this fix x64-windows MSVC link hang issue of ffmpeg? #28390

@Sibras
Copy link
Contributor Author

Sibras commented Jan 14, 2023

Will this fix x64-windows MSVC link hang issue of ffmpeg? #28390

No, not by itself but I do have a working solution for ffmpeg using this and other changes.
I put it up separately to help get things merged faster

@Sibras
Copy link
Contributor Author

Sibras commented Jan 14, 2023

Will this fix x64-windows MSVC link hang issue of ffmpeg? #28390

No, not by itself but I do have a working solution for ffmpeg using this and other changes. I put it up separately to help get things merged faster

Managed to fix the last remaining link issues with x86-windows and ffmpeg. It uses this PR and a new one for ffmpeg.
FFmpeg 5.1.2 28955

@reitowo
Copy link
Contributor

reitowo commented Jan 15, 2023

x86-windows?

Oh you mean x86 yasm problem, 👍🏻

@Sibras
Copy link
Contributor Author

Sibras commented Jan 15, 2023

x86-windows?

Oh you mean x86 yasm problem, 👍🏻

Yep, just it only really effects msvc hence breaking the x86-windows triplet

@Sibras
Copy link
Contributor Author

Sibras commented Jan 15, 2023

OK the CI failure is for 'zeroc-ice:x64-windows-static-md' which doesnt seem related at all to this PR. As the error logs suggest the process was just terminated (as opposed to an actual error) which is potentially just the CI timing out after ~1000mins??

testing locally it works fine so seems to just be the CI

@vicroms
Copy link
Member

vicroms commented Jan 15, 2023

Please merge with master to get rid of the CI failure.

@Adela0814 Adela0814 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jan 16, 2023
@Sibras
Copy link
Contributor Author

Sibras commented Jan 16, 2023

Now theres a x64-linux CI failure, but that appears to have been the result of an issue connecting to the website to download source and is unrelated to this PR (x64-linux CI passed when previously run)

@BillyONeal BillyONeal merged commit 19b64e8 into microsoft:master Jan 20, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Jan 20, 2023
@Sibras Sibras deleted the nasm branch January 20, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants