-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nasm] Update to 2.16.01. #28950
[nasm] Update to 2.16.01. #28950
Conversation
Will this fix x64-windows MSVC link hang issue of ffmpeg? #28390 |
No, not by itself but I do have a working solution for ffmpeg using this and other changes. |
Managed to fix the last remaining link issues with x86-windows and ffmpeg. It uses this PR and a new one for ffmpeg. |
x86-windows? Oh you mean x86 yasm problem, 👍🏻 |
Yep, just it only really effects msvc hence breaking the x86-windows triplet |
OK the CI failure is for 'zeroc-ice:x64-windows-static-md' which doesnt seem related at all to this PR. As the error logs suggest the process was just terminated (as opposed to an actual error) which is potentially just the CI timing out after ~1000mins?? testing locally it works fine so seems to just be the CI |
Please merge with master to get rid of the CI failure. |
Now theres a x64-linux CI failure, but that appears to have been the result of an issue connecting to the website to download source and is unrelated to this PR (x64-linux CI passed when previously run) |
Thanks for the update! |
Updates 'vcpkg_find_acquire_program' to use latest nasm release.