Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[robin-map] Update to 1.2.1 #28837

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

Tessil
Copy link
Contributor

@Tessil Tessil commented Jan 9, 2023

  • What does your PR fix?

Update robin-map to version 1.2.1

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions[bot]
github-actions bot previously approved these changes Jan 9, 2023
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 10, 2023
@@ -1,6 +1,6 @@
{
"name": "robin-map",
"version-semver": "1.0.1",
"version-semver": "1.2.1",
"port-version": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port-version": 1,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tessil, Thanks for your pr, we should remove "port-version" when we update the port version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5bb5f3923a33d862b25c18fd4514e08c74c698e1 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/r-/robin-map.json b/versions/r-/robin-map.json
index 5761600..7e2be2d 100644
--- a/versions/r-/robin-map.json
+++ b/versions/r-/robin-map.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "1f0de8df8eb08609cbc9eeb91cca774b0664b588",
+      "version-semver": "1.2.1",
+      "port-version": 0
+    },
     {
       "git-tree": "3d7f15cd096579c9633e2f25bc129e87fb6510ae",
       "version-semver": "1.2.1",

@Tessil Tessil force-pushed the update_robin_map_1_2_1 branch from 6199f83 to 33c7f97 Compare January 10, 2023 18:40
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 11, 2023
@vicroms vicroms merged commit 6e964f1 into microsoft:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants