Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zfp] update to 1.0.0 #28616

Merged
merged 16 commits into from
Feb 9, 2023
Merged

[zfp] update to 1.0.0 #28616

merged 16 commits into from
Feb 9, 2023

Conversation

JonLiu1993
Copy link
Member

Fix #28574

Update zfp to the latest version 1.0.0.
Modernize the portfile.cmake file

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Dec 29, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 29, 2022
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is a draft PR but I want to record some early comments.

@aavbsouza
Copy link

Any news on this issue ?

@MonicaLiu0311
Copy link
Contributor

Ping @JonLiu1993

github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the 1.0.0. release is an opportunity to trim the port's patching?

github-actions[bot]
github-actions bot previously approved these changes Feb 7, 2023
@JonLiu1993 JonLiu1993 requested a review from dg0yt February 7, 2023 10:55
github-actions[bot]
github-actions bot previously approved these changes Feb 8, 2023
@JonLiu1993 JonLiu1993 marked this pull request as ready for review February 8, 2023 02:32
github-actions[bot]
github-actions bot previously approved these changes Feb 8, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for zfp have changed but the version was not updated
version: 1.0.0
old SHA: d12ec77c899ac803e3d2094cd79febddd7790067
new SHA: d16beb0226d46bf535f4058b2c002e2c16f250c9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Feb 9, 2023
@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Feb 9, 2023
@JavierMatosD JavierMatosD merged commit 42d21b2 into microsoft:master Feb 9, 2023
@JonLiu1993 JonLiu1993 deleted the dev/Jon/zfp branch February 10, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zfp] update to 1.0
5 participants