[vcpkg_configure_cmake] Partially revert #26959 #28483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must avoid significant breaking changes to the sets of scripts coupled to the vcpkg tool version.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrankXie05
added
info:internal
|
I don't care too much about this revert but why can vcpkg not break stuff when there is a triplet escape hatch to unbreak? |
Because breaking stuff in this way causes users that upgrade the tool (not their libraries) to be broken. Our intent is that upgrading the vcpkg tool, if you're using manifests & versioning, will not break you. This is essential to promote and enable all users to quickly adopt new versions of the tool. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must avoid significant breaking changes to the sets of scripts coupled to the vcpkg tool version.
What does your PR fix?
Partially addresses #28386. @craigscott-crascit has identified this as a breaking change which is not permissible in the helper scripts bundled with the tool.