Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] update gas-preprocessor and clang in vcpkg_find_acquire_program #28467

Merged
merged 3 commits into from
Jan 12, 2023
Merged

[vcpkg] update gas-preprocessor and clang in vcpkg_find_acquire_program #28467

merged 3 commits into from
Jan 12, 2023

Conversation

reitowo
Copy link
Contributor

@reitowo reitowo commented Dec 20, 2022

Describe the pull request

Update gas-preprocessor and clang in vcpkg_find_acquire_program
Because if this update is included in port update PR, the CI will rebuild all ports and takes forever, so I fan out this PR.

github-actions[bot]
github-actions bot previously approved these changes Dec 20, 2022
View reviewed changes
@reitowo reitowo force-pushed the update-vcpkg-find-acquire-program branch from a9027e7 to 1017f0d Compare December 20, 2022 15:20
@FrankXie05 FrankXie05 added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Dec 21, 2022
@reitowo
Copy link
Contributor Author

reitowo commented Dec 21, 2022 •
edited
Loading

The regression of x64_windows_static seems have nothing to do with this PR as that port doesn't even use vcpkg_find_acquire_program at all.
#28459

@reitowo
Copy link
Contributor Author

reitowo commented Dec 22, 2022 •
edited
Loading

The regression of x64_osx seems have nothing to do with this PR as that port doesn't even use vcpkg_find_acquire_program at all.
The CI is over and the regressions seems have nothing to do with this PR's change, Can we merge this PR? @FrankXie05

@reitowo reitowo mentioned this pull request Dec 22, 2022
Closed
@FrankXie05
Copy link
Contributor

@cnSchwarzer I'm afraid we can only merge this PR if the ci is resolved. 😣

@reitowo
Copy link
Contributor Author

reitowo commented Dec 22, 2022 •
edited
Loading

OK, I'll wait until these ports are resolved. BTW is CI incremental or we need another 24h running?

@FrankXie05
Copy link
Contributor

FrankXie05 commented Dec 22, 2022 •
edited
Loading

We will solve the problem of ci as soon as possible and we have to re-run ci(corresponding triplets) to ensure that the problem is solved.

@reitowo reitowo mentioned this pull request Dec 23, 2022
Closed
5 tasks
@reitowo
Copy link
Contributor Author

reitowo commented Dec 24, 2022 •
edited
Loading

We will solve the problem of ci as soon as possible

@FrankXie05 Do you mean only rebuild ports that have reference to specific changed program? For example only rebuild ports that acquires program CLANG and GAS_PREPROCESSOR in this case. Thats seems difficult

@dg0yt
Copy link
Contributor

dg0yt commented Dec 24, 2022

For example only rebuild ports that acquires program CLANG and GAS_PREPROCESSOR in this case. Thats seems difficult

It is more or less what vcpkg CI already does. It determines the ports which are directly and transitively affected by your changes ("cone of destruction"), and rebuilds them if not cached. For this purpose, it must also install all unaffected ports which are dependencies. The total set of ports can pull in known baseline regressions, or uncover regressions for particular feature configurations or installation orders.

@reitowo
Copy link
Contributor Author

reitowo commented Dec 28, 2022

@FrankXie05 Can you rerun the ci? I think the problem is fixed

@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@reitowo reitowo mentioned this pull request Dec 31, 2022
Merged
@reitowo
Copy link
Contributor Author

reitowo commented Jan 7, 2023

REGRESSION: xxhash:* failed with FILE_CONFLICTS

@reitowo reitowo mentioned this pull request Jan 7, 2023
Closed
@FrankXie05
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@reitowo
Copy link
Contributor Author

reitowo commented Jan 10, 2023 •
edited
Loading

OK check passed, let's merge this please

@Neumann-A Neumann-A mentioned this pull request Jan 10, 2023
Closed
@reitowo
Copy link
Contributor Author

reitowo commented Jan 11, 2023 •
edited
Loading

@FrankXie05 @vicroms @JonLiu1993 @Neumann-A @Adela0814 Sorry for the noice but... Anyone can merge this please? Blocking multiple PR for a long time...🙏🏻

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jan 12, 2023
@vicroms vicroms merged commit 5b76887 into microsoft:master Jan 12, 2023
@reitowo reitowo deleted the update-vcpkg-find-acquire-program branch January 12, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reitowo @FrankXie05 @dg0yt @Neumann-A @vicroms @Cheney-W