[mathgl] Fix incorrect target name and incorrect executable path #28315
Conversation
LilyWangLL
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This overlaps with #28311. |
|
PS: Test non-default feautures, CI won't do it for us. |
LilyWangLL
added
the
requires:all-feature-testing
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/share/MathGL2/MathGLTargets-debug.cmake" | ||
| "${VCPKG_IMPORT_PREFIX}/debug/${PATH}/${TOOL_NAME}.exe" "${VCPKG_IMPORT_PREFIX}/tools/mathgl/${TOOL_NAME}.exe") | ||
| vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/share/MathGL2/MathGLTargets-release.cmake" | ||
| "${VCPKG_IMPORT_PREFIX}/${PATH}/${TOOL_NAME}.exe" "${VCPKG_IMPORT_PREFIX}/tools/mathgl/${TOOL_NAME}.exe") |
There was a problem hiding this comment.
IMO this is not the right fix. Normally, this should be handled by vcpkg_cmake_config_fixup. If it doesn't work, it might need a fix there.
There was a problem hiding this comment.
This action should be run before calling vcpkg_cmake_config_fixup to avoid executable target path is changed.
And we should use vcpkg_copy_tools since we should know which tools should be installed.
There was a problem hiding this comment.
I use vcpkg_copy_tools to handle tools before calling vcpkg_cmake_config_fixup, but the tools path in MathGLTargets-debug.cmake is still incorrect.
There was a problem hiding this comment.
I use
vcpkg_copy_toolsto handle tools before callingvcpkg_cmake_config_fixup, but the tools path inMathGLTargets-debug.cmakeis still incorrect.
Ah, I think you may need to make a patch to fix the tool installation path?
There was a problem hiding this comment.
#28311 is more complete. CI testing of widgets components showed more problems. That's why it is still in progress.
|
Closed as duplicate of #28311. |
Describe the pull request
What does your PR fix?
Fixes Could not find mathglConfig.cmake #28285, fixes CMake not able to find MathGL #22264