[vcpkg] Correct git version #25358
[vcpkg] Correct git version #25358
Conversation
JackBoosY
added
category:vcpkg-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
changed the title
|
@JackBoosY: Your are probably not fixing stuff here. The message should tell: Downloading git .... without mentioning the version |
|
@Neumann-A Nonono, in fact, even if no explicit download tool information is required, the version corresponding to the download url is incorrect. |
Oh, so we need to correct the warning info. |
|
We need vcpkgTools.xml to die |
|
in any case, if you force the VCPKG_FORCE_DOWNLOADED_BINARIES, this is what happens and it's not clear enough to the end user. Sad the PR has been closed |
If the problem is that the message we display isn't clear, that can't be fixed from here. The effect of rejecting perfectly good copies of git the user already has is not an improvement. |
|
the pr should then modify the downloaded version, putting an older version of git there. But at least be consistent with what it says it will download and what it downloads afterwards |
That doesn't make any sense to me. Just because we'll accept an existing copy has no bearing on the version of the copy we download. If we're going to download it anyway, we may as well download a current one.
That seems reasonable to me, but again, nothing in this PR could achieve that effect. It needs to be fixed over in vcpkg-tool |
Git was updated in #22985, but git version was wrongly restored by PR #23424.
Fixes #25339.