[wxwidgets] CMake re-run must not change libs #24499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dg0yt
force-pushed
the
wxwidgets-reconfigure
branch
from
c55edb6 to
e6dccec
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout c8a56fdc1594dfe134213c8c3edf1cc620e4fb37 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index d24eaa5..68bf462 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7530,7 +7530,7 @@
},
"wxwidgets": {
"baseline": "3.1.5",
- "port-version": 10
+ "port-version": 11
},
"x-plane": {
"baseline": "3.0.3",
diff --git a/versions/w-/wxwidgets.json b/versions/w-/wxwidgets.json
index 53c9c27..36019e7 100644
--- a/versions/w-/wxwidgets.json
+++ b/versions/w-/wxwidgets.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "530e4eea22c53907218b36f35308621723e9f8db",
+ "version-semver": "3.1.5",
+ "port-version": 11
+ },
{
"git-tree": "99203047a716a1b39d06fb93c48daebb4b184141",
"version-semver": "3.1.5",
dg0yt
force-pushed
the
wxwidgets-reconfigure
branch
from
eb9b76a to
f14ea0c
Compare
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for wxwidgets but no changes to version or port version.
-- Version: 3.1.5#10
-- Old SHA: 99203047a716a1b39d06fb93c48daebb4b184141
-- New SHA: 01fced0f27a5b09fccf3d4e43ab8b614fa2b7dc0
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
Windows CI test output (without the fix) is now: |
|
Thanks for the CI improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
[wxwidgets] vcpkg-cmake-wrapper.cmake causes failure to link debug libraries if project is reconfigured #24489.
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes