Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wxwidgets] Update to latest version 3.1.6 #24256

Closed
wants to merge 1 commit into from

Conversation

weather-tracker
Copy link

changed it to use latest of 3.16 instead of 3.15

Describe the pull request

  • What does your PR fix?

    Fixes #...

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    <Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

changed it to use latest of 3.16 instead of 3.15
@Cheney-W Cheney-W changed the title latest version is 3.16 [wxwidgets] Update to latest version 3.16 Apr 20, 2022
@Cheney-W
Copy link
Contributor

@weather-tracker Thanks for your PR.
If you want to update a version of the port, make sure that the following files are updated:
vcpkg.json (version)
portfile.cmake (version and SHA512)
patch file (remove or modify unsuitable patches)

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Apr 20, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Apr 20, 2022

It "3.1.6" not "3.16". It needs significant work to update the patches. (I just fixed 3.1.5 and added test coverage. I intentionally left 3.1.6 for a separate PR.)

@Cheney-W Cheney-W changed the title [wxwidgets] Update to latest version 3.16 [wxwidgets] Update to latest version 3.1.6 Apr 20, 2022
@talregev
Copy link
Contributor

talregev commented May 6, 2022

There is a PR of wxwidgets update to 3.1.6:
#24483
Can we close this PR?

@BillyONeal
Copy link
Member

Closing this PR as an exact duplicate of #24483 (And basically all changes missing)

@BillyONeal BillyONeal closed this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants