Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clipboardxx] Add new port #24023

Merged
merged 17 commits into from
Apr 14, 2022
Merged

Conversation

Pospelove
Copy link
Contributor

fixes #23938

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardcxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: ed17bcbdb40d0e200c2ad89ff1db833ee333bfe0
-- New SHA: c6688c208896d57ddd418eb94997e9a63d4d3645
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/clipboardcxx/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardcxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: ed17bcbdb40d0e200c2ad89ff1db833ee333bfe0
-- New SHA: 92f575bce3f4eb282588c2aa54644cfd3088643a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@JonLiu1993 JonLiu1993 self-assigned this Apr 8, 2022
@JonLiu1993 JonLiu1993 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Apr 8, 2022
@Pospelove
Copy link
Contributor Author

@JonLiu1993 sorry what kind of author response is required? 🤾

@Pospelove
Copy link
Contributor Author

@JonLiu1993 There is no review! 🆘 😭 🧦

@JonLiu1993
Copy link
Member

@JonLiu1993 sorry what kind of author response is required? 🤾

@Pospelove, I've made a review suggestion that you can apply

@Pospelove
Copy link
Contributor Author

@JonLiu1993 I don't see any review. Could you please log out from GitHub and view this page as a non-authorized user? #24023
It seems there is no review.

@Pospelove
Copy link
Contributor Author

@JonLiu1993 Maybe there is a review draft only visible to you?

@JonLiu1993
Copy link
Member

JonLiu1993 commented Apr 12, 2022

@JonLiu1993 Maybe there is a review draft only visible to you?

it doesn't matter I will modify it for you

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 12, 2022
@strega-nil-ms
Copy link
Contributor

This name is wrong - the port name should be clipboardxx, not clipboardcxx.

@strega-nil-ms strega-nil-ms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 12, 2022
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things need to be done:

  • please change the name
  • please use the CMake build

@JonLiu1993 JonLiu1993 changed the title [clipboardcxx] Add new port [clipboardxx] Add new port Apr 13, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8eacf9727a6454d4efd5e1222de773c69d5d8785 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 04fa740..9eeea0a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1424,6 +1424,10 @@
       "baseline": "2022-02-04",
       "port-version": 0
     },
+    "clipboardxx": {
+      "baseline": "2022-02-04",
+      "port-version": 0
+    },
     "clipp": {
       "baseline": "2019-04-30",
       "port-version": 1

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardcxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 51269b52d289604cc09bfece7e5a53b58181c490
-- New SHA: 593e8855bd22719ce7910065ccd1e3563872d164
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 51269b52d289604cc09bfece7e5a53b58181c490
-- New SHA: 2c7366f4a1cb07b19db178f6269f9d07ff65f35d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 8eacf9727a6454d4efd5e1222de773c69d5d8785 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 04fa740..9eeea0a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1424,6 +1424,10 @@
       "baseline": "2022-02-04",
       "port-version": 0
     },
+    "clipboardxx": {
+      "baseline": "2022-02-04",
+      "port-version": 0
+    },
     "clipp": {
       "baseline": "2019-04-30",
       "port-version": 1

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 51269b52d289604cc09bfece7e5a53b58181c490
-- New SHA: 2c7366f4a1cb07b19db178f6269f9d07ff65f35d
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 51269b52d289604cc09bfece7e5a53b58181c490
-- New SHA: 423ffc65287306733d42d0a214cc944930b76ab2
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 51269b52d289604cc09bfece7e5a53b58181c490
-- New SHA: eb225bb442f8798b391bc979800c916016b257e7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 423ffc65287306733d42d0a214cc944930b76ab2
-- New SHA: eb225bb442f8798b391bc979800c916016b257e7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 423ffc65287306733d42d0a214cc944930b76ab2
-- New SHA: 53badb5eac5eb5a6df928aa84da24a2545ef8dbf
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@Pospelove
Copy link
Contributor Author

@strega-nil-ms Thanks! Seems to be ok now

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 14, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for clipboardxx but no changes to version or port version.
-- Version: 2022-02-04
-- Old SHA: 53badb5eac5eb5a6df928aa84da24a2545ef8dbf
-- New SHA: eb4327df8801fc6dcfe971e07a467f30114f85dc
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

- add `supports: !osx`
- add `unofficial-clipboardxx-config.cmake`
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 1200c22 into microsoft:master Apr 14, 2022
@Pospelove Pospelove deleted the add-clipboardcxx branch April 14, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] ClipboardXX
4 participants