Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpff] Fix zlib import #23953

Merged
merged 4 commits into from
Apr 6, 2022
Merged

[libpff] Fix zlib import #23953

merged 4 commits into from
Apr 6, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Apr 2, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Fixes zlib import

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Removed from CI baseline; only supports dynamic & windows (not UWP)

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@Thomas1664 Thomas1664 changed the title [libpff] Fix Linux configure [libpff] Fixes zlib import Apr 4, 2022
@Thomas1664 Thomas1664 changed the title [libpff] Fixes zlib import [libpff] Fix zlib import Apr 4, 2022
@LilyWangLL LilyWangLL marked this pull request as ready for review April 6, 2022 07:35
@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Apr 6, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 0b1eb07 into microsoft:master Apr 6, 2022
@Thomas1664 Thomas1664 deleted the libpff2 branch April 6, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thomas1664 @strega-nil-ms @LilyWangLL