Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DiscordCoreAPI] Adding DiscordCoreAPI Discord bot library package. #23895

Merged
merged 142 commits into from
Apr 7, 2022
Merged

[DiscordCoreAPI] Adding DiscordCoreAPI Discord bot library package. #23895

merged 142 commits into from
Apr 7, 2022

Conversation

RealTimeChris
Copy link
Contributor

  • What does your PR fix?

Adds the DiscordCoreAPI Discord bot library.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Linux and Windows, and yes I have.

  • Does your PR follow the [maintainer guide]

Yes it does.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes I have.

Copy link
Contributor

@Cheney-W Cheney-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The records in versions/baseline.json and versions/d-/discordcoreapi.json are made by using
.\vcpkg x-add-version {port name}
to be added automatically.

@Cheney-W
Copy link
Contributor

If you need to modify this pr, please follow the steps below:

	• modify file
	• git add . 
	• git commit -m "comment"
	• .\vcpkg.exe x-add-version {port name} --overwrite-version 
	• git add .
	• git commit --amend --no-edit
        • git push

@Cheney-W Cheney-W added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Mar 31, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9d9a6f486cc7da7664117a75d01440db0088634a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 027d66f..9180cb5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1881,7 +1881,7 @@
       "port-version": 1
     },
     "discordcoreapi": {
-      "baseline": "1.0.2",
+      "baseline": "2022-03-30",
       "port-version": 0
     },
     "discount": {
diff --git a/versions/d-/discordcoreapi.json b/versions/d-/discordcoreapi.json
index b89985e..beef88f 100644
--- a/versions/d-/discordcoreapi.json
+++ b/versions/d-/discordcoreapi.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3b39e4db93192e92e834f220cfdd4737c7cb4de2",
+      "version-date": "2022-03-30",
+      "port-version": 0
+    },
     {
       "git-tree": "1766cb5385b3dc01537b9e1e09a58125f514f895",
       "version": "1.0.0",

@RealTimeChris RealTimeChris requested a review from Cheney-W March 31, 2022 07:12
@Cheney-W
Copy link
Contributor

If this port only works on Linux and Windows, please add "support" in the vcpkg.json file. For adding rules, please refer to: https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/manifest-files.md#supports

@Cheney-W
Copy link
Contributor

Which of the following triplet does this port support?

  • x86-windows
  • x64-windows
  • x64-windows-static
  • x64-uwp
  • x64-osx
  • x64-linux
  • arm-uwp
  • arm64-windows

@RealTimeChris
Copy link
Contributor Author

RealTimeChris commented Mar 31, 2022

Which of the following triplet does this port support?

  • x64-windows
  • x64-uwp
  • x64-linux

@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 7, 2022

@RealTimeChris
bb44c59
image
I saw you rolled back Nicole's changes. Did you disapprove of her modifications?

@Cheney-W Cheney-W added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 7, 2022
@RealTimeChris
Copy link
Contributor Author

@RealTimeChris bb44c59 image I saw you rolled back Nicole's changes. Did you disapprove of her modifications?

No it must have been a mistake! My apologies.

@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 7, 2022

.\vcpkg.exe x-add-version {port name} --overwrite-version

@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 7, 2022

You rolled back the value of support again.

@RealTimeChris
Copy link
Contributor Author

You rolled back the value of support again.

My mistake!

@Cheney-W
Copy link
Contributor

Cheney-W commented Apr 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 7, 2022
@strega-nil-ms
Copy link
Contributor

Thanks so much @RealTimeChris !

@strega-nil-ms strega-nil-ms merged commit c3ff2bf into microsoft:master Apr 7, 2022
@RealTimeChris
Copy link
Contributor Author

Thanks so much @RealTimeChris !

Thanks to you guys as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants