Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nsync] Export cmake targets #23811

Merged
merged 6 commits into from
Mar 28, 2022
Merged

[nsync] Export cmake targets #23811

merged 6 commits into from
Mar 28, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Mar 28, 2022 •
edited
Loading

Export target nsync and nsync_cpp.

Already tested the usage.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Mar 28, 2022
@JackBoosY JackBoosY mentioned this pull request Mar 28, 2022
Closed
@JackBoosY JackBoosY requested a review from LilyWangLL March 28, 2022 07:45
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 28, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Mar 28, 2022
@strega-nil-ms
Copy link
Contributor

LGTM, thanks!

@strega-nil-ms strega-nil-ms merged commit 2be2546 into microsoft:master Mar 28, 2022
@JackBoosY JackBoosY deleted the dev/jack/nsync-export-cmake branch March 29, 2022 00:11
@LilyWangLL LilyWangLL mentioned this pull request Jan 10, 2023
Closed
@luncliff luncliff mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @strega-nil-ms @LilyWangLL