-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c-dbg-macro] Add new port #23522
[c-dbg-macro] Add new port #23522
Conversation
a62eed4
to
f23e97c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/c-dbg-macro/vcpkg.json
Valid values for the license field can be found in the documentation
This breaks the ci:
|
@JonLiu1993 The conflict is when installing the second port from the set |
Not sure what to do about it. Renaming the header file when installing using vcpkg is possible, but could be confusing. However, the package in vcpkg is called c-dbg-macro, so a c as prefix might be ok? |
A file name as general as I need to repeat that there should be more care before adding ports. It can't be merge 2 days after the PR, even if trivial. |
Or use |
Describe the pull request
What does your PR fix?
Add new port
Which triplets are supported/not supported? Have you updated the CI baseline?
all, Yes (I think)
Does your PR follow the maintainer guide?
Probably not. A lot to read.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes