Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libheif] Fix usage #22818

Merged
merged 4 commits into from
Jan 28, 2022
Merged

[libheif] Fix usage #22818

merged 4 commits into from
Jan 28, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jan 27, 2022 •
edited
Loading

Fix definiton LIBHEIF_API value.

#if defined(_MSC_VER) && !defined(LIBHEIF_STATIC_BUILD)
#ifdef LIBHEIF_EXPORTS
#define LIBHEIF_API __declspec(dllexport)
#else
#define LIBHEIF_API __declspec(dllimport)
#endif
#elif defined(HAVE_VISIBILITY) && HAVE_VISIBILITY
#ifdef LIBHEIF_EXPORTS
#define LIBHEIF_API __attribute__((__visibility__("default")))
#else
#define LIBHEIF_API
#endif
#else
#define LIBHEIF_API
#endif

Fixes #13354 #18107.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 27, 2022
@JackBoosY JackBoosY mentioned this pull request Jan 27, 2022
Closed
github-actions[bot]
github-actions bot approved these changes Jan 27, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libheif/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JackBoosY JackBoosY mentioned this pull request Jan 27, 2022
Closed
@JackBoosY JackBoosY linked an issue Jan 27, 2022 that may be closed by this pull request
[libheif] Fix static linking #18107
Closed
@LilyWangLL
Copy link
Contributor

LilyWangLL commented Jan 27, 2022 •
edited
Loading

Could you add license in vcpkg.json for libheif?

@JackBoosY JackBoosY requested a review from LilyWangLL January 27, 2022 16:23
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 28, 2022
@ras0219-msft ras0219-msft merged commit 8e7e20c into microsoft:master Jan 28, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/13354 branch January 29, 2022 04:40
@saucecontrol saucecontrol mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libheif] Fix static linking [openimageio[opencolorio] / libheif] Linking against OpenImageIO failed
3 participants
@JackBoosY @LilyWangLL @ras0219-msft