Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpg123] Upgrade to 1.29.2 #21565

Merged
merged 3 commits into from
Nov 22, 2021
Merged

[mpg123] Upgrade to 1.29.2 #21565

merged 3 commits into from
Nov 22, 2021

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented Nov 21, 2021

  • Upgrade 1.28.0 -> 1.29.2
  • Avoid deprecated helper functions
  • Remove unused patches

The bug from #18949 was fixed by upstream.

@evpobr evpobr marked this pull request as draft November 21, 2021 06:47
* Upgrade 1.28.0 -> 1.29.2
* Avoid deprecated helper functions
* Remove unused patches
@evpobr evpobr marked this pull request as ready for review November 21, 2021 07:56
@JonLiu1993 JonLiu1993 self-assigned this Nov 22, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 22, 2021
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 22, 2021
@BillyONeal
Copy link
Member

Thanks for the update and verifying function without patches!

@BillyONeal BillyONeal merged commit e48805d into microsoft:master Nov 22, 2021
@daschuer
Copy link
Contributor

This fails now on x64-linux because of missing jack dependency.

/mnt/vcpkg-ci/buildtrees/mpg123/src/ffb82ffbeb-4155379e21.clean/src/libout123/modules/jack.c:21:10: fatal error: jack/jack.h: No such file or directory
   21 | #include <jack/jack.h>
      |          ^~~~~~~~~~~~~

@daschuer daschuer mentioned this pull request Dec 14, 2021
@JackBoosY
Copy link
Contributor

I will handle this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants