-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libmount] New port #21491
[libmount] New port #21491
Conversation
All features have been tested with and without and behave as expected:
|
FYI, Windows CI/CD cascades kf5 ports. See microsoft/vcpkg-tool#184 (comment) |
In |
Sorry, I see it is meant to work in |
This is now solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Additionally required by kf5kio | ||
APT_PACKAGES="$APT_PACKAGES libmount-dev" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinging @BillyONeal to ok this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this was added by myself only recently as part of preparation for #20938 (still unmerged).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since reviewing this I made libmount
a default feature on Linux for kf5solid
, as well as updated the FindLibMount.cmake
after upstream had some suggestions.
99bcb11
to
5293339
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 653912591af709c162fba2d4000a6b3362c8d3c9 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/e-/ecm.json b/versions/e-/ecm.json
index 0376164..ccfbb4d 100644
--- a/versions/e-/ecm.json
+++ b/versions/e-/ecm.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "b9ea21e7dd8a4191cedd825fee0a22045f2d587d",
+ "git-tree": "0bd4113f8c0da00ac67473e5e52644036f1147ba",
"version": "5.84.0",
"port-version": 3
},
LGTM, @BillyONeal can you please review again? Thanks. |
Thanks for the port :) |
Describe the pull request
- Adds new port
- Updates other ports (
kf5kio
,kf5solid
,glib
) to take advantage of it- removes now redundant
libmount-dev
package from the linux VMWhat does your PR fix?
See [vcpkg baseline][kf5solid] Fix usage #21344
Which triplets are supported/not supported? Have you updated the CI baseline?
Linux.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes