Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdal] Update to 3.4.0, minor adjustments #21261

Merged
merged 7 commits into from
Nov 13, 2021
Merged

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 8, 2021

@dg0yt dg0yt changed the title [gdal] Update to 3.4, minor adjustments [gdal] Update to 3.4.0, minor adjustments Nov 8, 2021
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Nov 9, 2021
@JackBoosY JackBoosY added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Nov 9, 2021
@JackBoosY
Copy link
Contributor

When building gdal[*]:x64-windows-static:

	cl   /nologo /MP%NUMBER_OF_PROCESSORS% /MT /EHsc /Ox /D_CRT_SECURE_NO_DEPRECATE /D_CRT_NONSTDC_NO_DEPRECATE /DNDEBUG /W3 /wd4127 /wd4251 /wd4275 /wd4786 /wd4100 /wd4245 /wd4206 /wd4351 /wd4611  /DHAVE_SSE_AT_COMPILE_TIME /DHAVE_SSSE3_AT_COMPILE_TIME -I..\port -I..\ogr -I..\gcore  -I..\alg -I..\ogr\ogrsf_frmts  -I..\gnm -I..\gnm\gnm_frmts -I..\apps /DHAVE_AVX_AT_COMPILE_TIME -I..\frmts\vrt -I..\ogr\ogrsf_frmts\geojson\libjson -I..\ogr\ogrsf_frmts\geojson -I..\ogr\ogrsf_frmts\generic -IG:/21261/vcpkg/installed/x64-windows-static/include -DHAVE_GEOS -IG:/21261/vcpkg/installed/x64-windows-static/include  -DGNM_ENABLED  -DGDAL_COMPILATION gdal_translate_bin.cpp  ..\gdal.lib  /Fegdal_translate.exe /link   
gdal_translate_bin.cpp
   Creating library gdal_translate.lib and object gdal_translate.exp
gdal.lib(ogrmysqldriver.obj) : error LNK2019: unresolved external symbol mysql_server_init referenced in function "class GDALDataset * __cdecl OGRMySQLDriverOpen(class GDALOpenInfo *)" (?OGRMySQLDriverOpen@@YAPEAVGDALDataset@@PEAVGDALOpenInfo@@@Z)
gdal.lib(ogrmysqldriver.obj) : error LNK2019: unresolved external symbol mysql_server_end referenced in function "void __cdecl OGRMySQLDriverUnload(class GDALDriver *)" (?OGRMySQLDriverUnload@@YAXPEAVGDALDriver@@@Z)
gdal.lib(ogrsqlitedatasource.obj) : error LNK2001: unresolved external symbol spatialite_version
gdal.lib(ogrsqlitedatasource.obj) : error LNK2019: unresolved external symbol spatialite_init referenced in function "int __cdecl OGRSQLiteInitOldSpatialite(void)" (?OGRSQLiteInitOldSpatialite@@YAHXZ)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_num_rows referenced in function "public: int __cdecl OGRMySQLDataSource::FetchSRSId(class OGRSpatialReference *)" (?FetchSRSId@OGRMySQLDataSource@@QEAAHPEAVOGRSpatialReference@@@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_field_count referenced in function "public: virtual class OGRLayer * __cdecl OGRMySQLDataSource::ExecuteSQL(char const *,class OGRGeometry *,char const *)" (?ExecuteSQL@OGRMySQLDataSource@@UEAAPEAVOGRLayer@@PEBDPEAVOGRGeometry@@0@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_affected_rows referenced in function "public: virtual class OGRLayer * __cdecl OGRMySQLDataSource::ExecuteSQL(char const *,class OGRGeometry *,char const *)" (?ExecuteSQL@OGRMySQLDataSource@@UEAAPEAVOGRLayer@@PEBDPEAVOGRGeometry@@0@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_affected_rows
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_error referenced in function "public: virtual class OGRLayer * __cdecl OGRMySQLDataSource::ExecuteSQL(char const *,class OGRGeometry *,char const *)" (?ExecuteSQL@OGRMySQLDataSource@@UEAAPEAVOGRLayer@@PEBDPEAVOGRGeometry@@0@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_init referenced in function "public: int __cdecl OGRMySQLDataSource::Open(char const *,char * *,int)" (?Open@OGRMySQLDataSource@@QEAAHPEBDPEAPEADH@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_real_connect referenced in function "public: int __cdecl OGRMySQLDataSource::Open(char const *,char * *,int)" (?Open@OGRMySQLDataSource@@QEAAHPEBDPEAPEADH@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_close referenced in function "public: virtual __cdecl OGRMySQLDataSource::~OGRMySQLDataSource(void)" (??1OGRMySQLDataSource@@UEAA@XZ)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_query referenced in function "private: virtual int __cdecl OGRMySQLDataSource::DeleteLayer(int)" (?DeleteLayer@OGRMySQLDataSource@@EEAAHH@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_query
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2001: unresolved external symbol mysql_query
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_query
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_store_result referenced in function "public: class OGRSpatialReference * __cdecl OGRMySQLDataSource::FetchSRS(int)" (?FetchSRS@OGRMySQLDataSource@@QEAAPEAVOGRSpatialReference@@H@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_store_result
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2001: unresolved external symbol mysql_store_result
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_store_result
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_use_result referenced in function "public: virtual class OGRLayer * __cdecl OGRMySQLDataSource::ExecuteSQL(char const *,class OGRGeometry *,char const *)" (?ExecuteSQL@OGRMySQLDataSource@@UEAAPEAVOGRLayer@@PEBDPEAVOGRGeometry@@0@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_use_result
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_use_result
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_options referenced in function "public: int __cdecl OGRMySQLDataSource::Open(char const *,char * *,int)" (?Open@OGRMySQLDataSource@@QEAAHPEBDPEAPEADH@Z)
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_free_result referenced in function "public: class OGRSpatialReference * __cdecl OGRMySQLDataSource::FetchSRS(int)" (?FetchSRS@OGRMySQLDataSource@@QEAAPEAVOGRSpatialReference@@H@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_free_result
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2001: unresolved external symbol mysql_free_result
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_free_result
gdal.lib(ogrmysqldatasource.obj) : error LNK2019: unresolved external symbol mysql_fetch_row referenced in function "public: class OGRSpatialReference * __cdecl OGRMySQLDataSource::FetchSRS(int)" (?FetchSRS@OGRMySQLDataSource@@QEAAPEAVOGRSpatialReference@@H@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2001: unresolved external symbol mysql_fetch_row
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2001: unresolved external symbol mysql_fetch_row
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_fetch_row
gdal.lib(ogrmysqltablelayer.obj) : error LNK2019: unresolved external symbol mysql_insert_id referenced in function "public: virtual int __cdecl OGRMySQLTableLayer::ICreateFeature(class OGRFeature *)" (?ICreateFeature@OGRMySQLTableLayer@@UEAAHPEAVOGRFeature@@@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2019: unresolved external symbol mysql_errno referenced in function "public: virtual int __cdecl OGRMySQLTableLayer::ICreateFeature(class OGRFeature *)" (?ICreateFeature@OGRMySQLTableLayer@@UEAAHPEAVOGRFeature@@@Z)
gdal.lib(ogrmysqltablelayer.obj) : error LNK2019: unresolved external symbol mysql_fetch_lengths referenced in function "public: virtual int __cdecl OGRMySQLTableLayer::GetExtent(class OGREnvelope *,int)" (?GetExtent@OGRMySQLTableLayer@@UEAAHPEAVOGREnvelope@@H@Z)
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_fetch_lengths
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2019: unresolved external symbol mysql_num_fields referenced in function "public: class OGRFeatureDefn * __cdecl OGRMySQLResultLayer::ReadResultDefinition(void)" (?ReadResultDefinition@OGRMySQLResultLayer@@QEAAPEAVOGRFeatureDefn@@XZ)
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_num_fields
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2019: unresolved external symbol mysql_field_seek referenced in function "public: class OGRFeatureDefn * __cdecl OGRMySQLResultLayer::ReadResultDefinition(void)" (?ReadResultDefinition@OGRMySQLResultLayer@@QEAAPEAVOGRFeatureDefn@@XZ)
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_field_seek
gdal.lib(ogrmysqlresultlayer.obj) : error LNK2019: unresolved external symbol mysql_fetch_field referenced in function "public: class OGRFeatureDefn * __cdecl OGRMySQLResultLayer::ReadResultDefinition(void)" (?ReadResultDefinition@OGRMySQLResultLayer@@QEAAPEAVOGRFeatureDefn@@XZ)
gdal.lib(ogrmysqllayer.obj) : error LNK2001: unresolved external symbol mysql_fetch_field
gdal_translate.exe : fatal error LNK1120: 23 unresolved externals

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 10, 2021

gdal[*]:x64-windows-static

I think the static linkage issues existed before and are not regressions. It is just hidden from CI due to opt-in features. But I can look at it as long as I have other PRs waiting for merge. There will be merge conflicts anyway.

@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 13, 2021

gdal[*]:x64-windows-static

I think the static linkage issues existed before and are not regressions. It is just hidden from CI due to opt-in features. But I can look at it as long as I have other PRs waiting for merge. There will be merge conflicts anyway.

Really no regressions, so please don't hold back this PR. The merge conflicts from the libgeotiff update are resolved now.

I am already working on the non-default features in separate PRs. If it helps with tracking, I can open an issue listing all gdal port sub-issues and related PRs.

@ras0219-msft ras0219-msft merged commit 72059f6 into microsoft:master Nov 13, 2021
@ras0219-msft
Copy link
Contributor

This LGTM, thanks for the great work as always!

@dg0yt dg0yt deleted the gdal-3.4 branch November 14, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants