Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geos] Update to 3.10.0 #21051

Merged
merged 7 commits into from
Nov 9, 2021
Merged

[geos] Update to 3.10.0 #21051

merged 7 commits into from
Nov 9, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 29, 2021

  • What does your PR fix?

    Update geos to 3.10.0.
    Enables build on uwp.
    Exports -lm usage requirement in pc file and config script (i.e. fixes port bug).

    CMake is an official build system now. There were significant improvements upstream, but the exported configuration still needs fixup for vcpkg.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, yes

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b963638b5fd08bc1b20cc603bd92e0d6e3d24565 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cbbdd60..21aa87a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2381,8 +2381,8 @@
       "port-version": 1
     },
     "geos": {
-      "baseline": "3.9.1",
-      "port-version": 3
+      "baseline": "3.10.0",
+      "port-version": 0
     },
     "geotrans": {
       "baseline": "3.8",
diff --git a/versions/g-/geos.json b/versions/g-/geos.json
index 0f7002d..5ae0d0e 100644
--- a/versions/g-/geos.json
+++ b/versions/g-/geos.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c282ae7804f031b6b35aee91af91085f17bdd16c",
+      "version": "3.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9a0a3db2edc588598505038b452c9c7c91c1be6e",
       "version": "3.9.1",

@NancyLi1013 NancyLi1013 self-assigned this Oct 29, 2021
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 29, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b963638b5fd08bc1b20cc603bd92e0d6e3d24565 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cbbdd60..21aa87a 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2381,8 +2381,8 @@
       "port-version": 1
     },
     "geos": {
-      "baseline": "3.9.1",
-      "port-version": 3
+      "baseline": "3.10.0",
+      "port-version": 0
     },
     "geotrans": {
       "baseline": "3.8",
diff --git a/versions/g-/geos.json b/versions/g-/geos.json
index 0f7002d..5bf0128 100644
--- a/versions/g-/geos.json
+++ b/versions/g-/geos.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "c36156409f7ef1a3fc13dc5b865d80fef52d9541",
+      "version": "3.10.0",
+      "port-version": 0
+    },
     {
       "git-tree": "9a0a3db2edc588598505038b452c9c7c91c1be6e",
       "version": "3.9.1",

@dg0yt dg0yt marked this pull request as ready for review October 29, 2021 07:40
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 29, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 29, 2021

Also tested on mingw static and dynamic.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Nov 1, 2021
@dg0yt
Copy link
Contributor Author

dg0yt commented Nov 9, 2021

@dan-shaw @BillyONeal Ping for merge. A blocker for other work.

@BillyONeal BillyONeal merged commit ce73eeb into microsoft:master Nov 9, 2021
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the geos branch November 13, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants