[rsm-binary-io] Add new port #20334
Merged
[rsm-binary-io] Add new port #20334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mrgreen2017
reviewed
Sep 25, 2021
| @@ -1364,6 +1364,8 @@ rsasynccpp:arm-uwp=fail | |||
| rsasynccpp:x64-linux=fail | |||
| rsasynccpp:x64-osx=fail | |||
| # Requires g++10 but CI compiler only has g++9 | |||
PhoebeHui
added
the
category:new-port
PhoebeHui
requested changes
Sep 26, 2021
There was a problem hiding this comment.
@Ryan-rsm-McKenzie, thanks for your PR!
Could you change the 'tab' to 'space' in portfile.cmake?
PhoebeHui
approved these changes
Sep 26, 2021
PhoebeHui
added
info:reviewed
|
Thanks for the new port! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds a new port binary_io
Which triplets are supported/not supported? Have you updated the CI baseline?
Supports only Linux/Windows + static linkage, and requires at least GCC 10
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes