-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scripts-audit] QMake buildsystem #20322
Merged
strega-nil-ms
merged 21 commits into
microsoft:master
from
JackBoosY:dev/jack/script-audit-qmake
Nov 5, 2021
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3309504
[scripts-audit] QMake buildsystem
eb09cce
Apply suggestions
4d2662e
Change qt5-base as a host port
eea7118
version
3a91f67
Fix installation
378c76b
Apply suggestions
3b491bb
Update doc
28f2b4d
Typo
508f396
update doc
521f16e
Fix bug
56c72e1
fix vcpkg_host_path_list issue
77bcb0a
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
febedcb
Process more host path
eaa6074
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
c1b186c
Apply suggestions
e73688f
Apply suggestions
841f179
Apply suggestions from code review
strega-nil-ms f9ef83c
more changes
strega-nil 17c5b77
Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…
d53b703
Merge branch 'dev/jack/script-audit-qmake' of https://github.com/Jack…
b4b13cb
Apply suggestions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may have been the intention by name, but does it make sense for qmake? There is no "build step" in
vcpkg_configure_qmake
and also no documented effect of--
in https://doc.qt.io/qt-5/qmake-manual.html.CC @Neumann-A
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just means non parametric options after the
--
.BUILD_OPTIONS
might be the wrong name here and it was a bit influenced by qt5-base bootstrap script where it is needed to pass other variables to the next build/configure step.BUILD_OPTIONS
is used in in e.g. qt5-webengine.