-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kf5sonnet] new port #19199
[kf5sonnet] new port #19199
Conversation
@hellozee much of it was your work, so please test again on your end if possible |
Ahh sure, 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrobelda, thanks for your PR!
These functions has been deprecated: vcpkg_configure_cmake, vcpkg_install_cmake and vcpkg_fixup_cmake_targets
Co-authored-by: Phoebe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for kf5sonnet but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 21192a2c743248da5a13e0607b89d31a3b6b32ee
-- New SHA: 1ed4193f678655f491962fb9e4f76d808d1ea1ac
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/kf5sonnet/vcpkg.json b/ports/kf5sonnet/vcpkg.json
index bd254e3..8f4b783 100644
--- a/ports/kf5sonnet/vcpkg.json
+++ b/ports/kf5sonnet/vcpkg.json
@@ -7,7 +7,7 @@
"ecm",
"qt5-base",
"qt5-tools",
- {
+ {
"name": "vcpkg-cmake",
"host": true
},
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for kf5sonnet but no changes to version or port version.
-- Version: 5.84.0
-- Old SHA: 21192a2c743248da5a13e0607b89d31a3b6b32ee
-- New SHA: 4f3d282f2a0bf80b1924449f5273fc38b33b548f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Co-authored-by: Phoebe <[email protected]>
Thanks! Totally forgot about it. All fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your updates!
Many projects will have more than a single license. Such projects typically have a LICENSES folder with SPDX copies of them. This explains how to copy them all instead just a single one. Such projects with multiple licenses should be officially recognized, so that maintainers are aware of it. See e.g.: microsoft#19199 (review) microsoft#19200 (comment)
Describe the pull request
What does your PR fix?
Adds new port
Which triplets are supported/not supported? Have you updated the CI baseline?
All official triplets.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.