-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imguizmo] new port #18991
Merged
Merged
[imguizmo] new port #18991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
requested changes
Jul 19, 2021
JonLiu1993
requested changes
Jul 19, 2021
JonLiu1993
requested changes
Jul 19, 2021
Co-authored-by: JonLiu1993 <[email protected]>
3a36a7b
to
3062585
Compare
7ed190b
to
64ab82f
Compare
Does osx run without std11 even? |
@JonathanHiggs, you need 'add_compile_options(-std=c++11)' in your CMakeLists.txt for osx if it needed. |
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
reviewed
Jul 20, 2021
Co-authored-by: Phoebe <[email protected]>
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
reviewed
Jul 20, 2021
Is it |
@JonathanHiggs, please use target_compile_options(). |
Co-authored-by: Phoebe <[email protected]>
PhoebeHui
reviewed
Jul 20, 2021
PhoebeHui
approved these changes
Jul 20, 2021
PhoebeHui
approved these changes
Jul 21, 2021
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a port for the ImGuizmo library to go along with ImGui and ImPlot
Source library uses a make build so this port uses the same method of ImPlot to define a
CMakeLists.txt
in the port and copy it over during install to correctly build the projectSource library is not versioned, I have an open issue about whether there they will use releases. Currently I am using a yyyy-mm-dd as the version string
What does your PR fix?
Adds a port for ImGuizmo
Which triplets are supported/not supported? Have you updated the [CI baseline]
Tested x86-windows, x64-windows, x64-linux sucessfully, unable to test others
Does your PR follow the maintainer guide?
As far as I know. Port is very similar to pre-existing ImPlot port, and the example code in source repo is excluded by the custom
CMakeLists.txt
included in the port directoryIf you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/