[vcpkg_download_distfile] Pad the SHA to re-enable testing the hash

[ras0219]

No description provided.

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[autoantwort]

Yeah but now it doesn't work anymore if I use 1 as SHA, or something else

[ras0219-msft]

That's true, but I think for the purposes of local development it is not a burden to require use of the literal 0 (esp. compared with the burden of synthesizing exactly 128 0's). Most importantly, the error messages should make the path forward clear.

[autoantwort]

That's true, but I think for the purposes of local development it is not a burden to require use of the literal 0 (esp. compared with the burden of synthesizing exactly 128 0's).

The code to fill up the hash with zeros up to a string length of 128 was not that complicated.

Most importantly, the error messages should make the path forward clear.

No, it only shows that I have entered an invalid sha, e.g. for the input 1. Imho not very user friendly. Imho it should just do it like in your first version, it is the easiest one for the users.

[NancyLi1013]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil-ms]

Thanks again robert!

[autoantwort]

When you stick with the only 0 way you should update the documentation here, because there you say that users should use 1