-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] vcpkg_from_github beast moved to boost-beast #18106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
@PhoebeHui any idea why the checks failed? |
@strega-nil-ms, could you please take a look? the format.diff suggest to update to original change. format.diff
|
The "source of truth" for documentation is stored in the helper: https://github.com/Microsoft/vcpkg/blob/master/scripts/cmake/vcpkg_from_github.cmake. We generate the .md file from the helper file using https://github.com/microsoft/vcpkg/blob/master/docs/regenerate.ps1. You can either make the change in both places, or just make the change in the |
@ras0219 thanks! |
@ras0219 @PhoebeHui looks like it's done! The PR failures in Linux and Windows are download failures for ncurses and libsbml respectively. |
The failures on realsense2:x64-osx would be addressed by PR #18202. I would rerun the CI test after the PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may delay merging this change since it touches vcpkg_from_github.cmake
and therefore the package hashes of most packages, but thanks for the PR!
Describe the pull request
Came across the webpage on vcpkg.io which took me to an empty beast file.
boost-beast has moved from beast to boost-beast