Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsio] Add new port #17789

Merged
merged 14 commits into from
May 13, 2021
Merged

[bsio] Add new port #17789

merged 14 commits into from
May 13, 2021

Conversation

IronsDu
Copy link
Contributor

@IronsDu IronsDu commented May 11, 2021

Describe the pull request

  • What does your PR fix?

    add new port which name is bsio.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    ,

  • Does your PR follow the maintainer guide?

    Your answer

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    <Yes / I am still working on this PR>

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@IronsDu
Copy link
Contributor Author

IronsDu commented May 11, 2021

@NancyLi1013 Hi, can you review this pr ? thank you.

@NancyLi1013 NancyLi1013 changed the title add the port of bsio library [bsio] Add new port May 11, 2021
@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 11, 2021
@NancyLi1013 NancyLi1013 self-assigned this May 11, 2021
@JackBoosY
Copy link
Contributor

Please run ./vcpkg format-manifest --all then commit changes.

@IronsDu IronsDu requested a review from NancyLi1013 May 12, 2021 06:50
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 12, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for adding this new port @IronsDu.

@IronsDu
Copy link
Contributor Author

IronsDu commented May 13, 2021

thank you @JackBoosY @NancyLi1013 review my PR.

@dan-shaw dan-shaw merged commit eba9197 into microsoft:master May 13, 2021
@IronsDu IronsDu deleted the add-bsio branch May 14, 2021 00:25
@IronsDu
Copy link
Contributor Author

IronsDu commented May 14, 2021

@JackBoosY can you add my weixin: 158..82..12608.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants