Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[avcpp] Add new port #17716

Merged
merged 4 commits into from
May 18, 2021
Merged

[avcpp] Add new port #17716

merged 4 commits into from
May 18, 2021

Conversation

barcharcraz
Copy link
Member

Adds the AvCpp library, it's static only because they don't export their dynamic libraries.

@barcharcraz
Copy link
Member Author

They don't export any symbols from their dynamic libraries that is.

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 7, 2021
@PhoebeHui PhoebeHui changed the title Add AvCpp [avcpp] Add new port May 7, 2021
PhoebeHui
PhoebeHui requested changes May 7, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barcharcraz, thanks for your contribution!

@PhoebeHui
Copy link
Contributor

@barcharcraz, could you format the vcpkg.json file? you can simply apply the following patch:
format.diff.zip

@barcharcraz
Copy link
Member Author

applied comments.

@barcharcraz barcharcraz requested a review from PhoebeHui May 12, 2021 00:05
PhoebeHui
PhoebeHui approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label May 12, 2021
@dan-shaw dan-shaw merged commit 113880e into microsoft:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barcharcraz @PhoebeHui @JackBoosY @dan-shaw