Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cryptopp] Update to 8.5.0 #17533

Merged
merged 3 commits into from
May 6, 2021
Merged

[cryptopp] Update to 8.5.0 #17533

merged 3 commits into from
May 6, 2021

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Apr 27, 2021

This PR updates Crypto++ to 8.5.0. It also re-enables assembly in macOS builds, which appears to be working correctly now.

  • What does your PR fix?

    Updates Crypto++ to version 8.5.0

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Tested on Windows (x86/x64/ARM64), macOS (x64/ARM64), Linux (Debian 10 x86_64)

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Apr 27, 2021
@JackBoosY
Copy link
Contributor

Depends on #17528

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Apr 28, 2021
@JackBoosY JackBoosY added requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 28, 2021
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 30, 2021
@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels May 6, 2021
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplets:

  • x64-windows
  • x64-windows-static

@strega-nil-ms
Copy link
Contributor

Thanks @orudge :)

@strega-nil-ms strega-nil-ms merged commit 2a4749e into microsoft:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 left review comments

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orudge @JackBoosY @JonLiu1993 @strega-nil-ms