Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] link to new functions in deprecated warnings #17179

Merged
merged 7 commits into from
May 9, 2021

Conversation

autoantwort
Copy link
Contributor

Describe the pull request

  • What does your PR fix?
    Make it easier to find the new functions

  • Does your PR follow the maintainer guide? Yes

@autoantwort
Copy link
Contributor Author

seems like i have to learn powershell

@PhoebeHui PhoebeHui added the category:documentation To resolve the issue, documentation will need to be updated label Apr 12, 2021
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor

The failures in CI pipeline:

Traceback (most recent call last):
  File "/Volumes/data/work/1/s/scripts/file_script.py", line 34, in main
    gen_all_file_strings(path, getFiles(path), headers, output)
  File "/Volumes/data/work/1/s/scripts/file_script.py", line 20, in gen_all_file_strings
    output.write(package + ":" + line[idx-1:])
OSError: [Errno 28] No space left on device

@PhoebeHui
Copy link
Contributor

The popsift failure in pipeline would be fixed by #17277

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Apr 16, 2021
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but it changes the hashes for the world, so we should merge it with other world-wide changes.

@BillyONeal
Copy link
Member

I like this change, but it changes the hashes for the world, so we should merge it with other world-wide changes.

Should we consider not putting docs content in the actual .cmakes so that changes to them don't invalidate world hashes?

@strega-nil-ms strega-nil-ms merged commit f44d4c1 into microsoft:master May 9, 2021
@strega-nil-ms
Copy link
Contributor

Thanks!

@autoantwort autoantwort deleted the add-links-to-new branch September 1, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants