-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cpuinfo,fbgemm,nnpack] update to latest source version and rename targets #17063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is no the upstream changes, we should add prefix unofficial-
.
Cool. There are some ports I worked to use this, but let me fix them after this |
Co-authored-by: Jack·Boos·Yu <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
Co-authored-by: Jack·Boos·Yu <[email protected]>
I think you should remake the patch file. |
* fixup target path to `share/unofficial-cpuinfo` * change IMPORTED target name to `unofficial::cpuinfo::cpuinfo`
* change cpuinfo::cpuinfo to unofficial
I think that that's incorrect; they're just corrections of upstream targets, so they should be under the upstream name, not |
@strega-nil-ms The upstream doesn't export any targets in the master branch, did I miss something? |
@JackBoosY oh... yeah you're right, I totally misread that, you're right. |
Thanks @luncliff :) |
What does your PR fix?
cpuinfo
to use the latest source code.cpuinfo-pull-22-868bd11.patch
CONTROL
tovcpkg.json
.IMPORTED
target namesapcecpuinfo::
tounofficial::cpuinfo::
The previous patch
cpuinfo-pull-22-868bd11.patch
, which is from pytorch/cpuinfo#22 failed to apply.Picked those differences and created a new patch file.
What a sad that PR is not merged yet ...
Which triplets are supported/not supported? Have you updated the CI baseline?
No change in triplet support. The current build check must be passed.
Target namespace changed
Does your PR follow the maintainer guide?
I think so.