Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Vulkan SDK usage for Android triplets #16881

Merged
merged 4 commits into from
Mar 29, 2021
Merged

[docs] Vulkan SDK usage for Android triplets #16881

merged 4 commits into from
Mar 29, 2021

Conversation

luncliff
Copy link
Contributor

@luncliff luncliff commented Mar 25, 2021

What does your PR fix?

Add a short description/sample for vulkan package with NDK.

For preview: https://github.com/microsoft/vcpkg/blob/master/docs/users/android.md#using-vulkan-sdk

Does your PR follow the maintainer guide?

Will be glad to hear about the style, link usage, etc.

* redirect to developer.android.com for some keywords
@Cheney-W Cheney-W self-assigned this Mar 26, 2021
@Cheney-W Cheney-W added category:documentation To resolve the issue, documentation will need to be updated requires:author-response labels Mar 26, 2021
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 26, 2021
@luncliff
Copy link
Contributor Author

luncliff commented Mar 26, 2021

Added more detailed path examples for find_library users. --> 4004fb7

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Mar 26, 2021
@Cheney-W
Copy link
Contributor

Cheney-W commented Mar 26, 2021

osgearth:x64-linux failure is a CI issue, it will be fixed by PR #16904.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 26, 2021
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Mar 29, 2021
@vicroms
Copy link
Member

vicroms commented Mar 29, 2021

This is very useful, thanks for the PR!

@vicroms vicroms merged commit 2b903ed into microsoft:master Mar 29, 2021
@luncliff luncliff deleted the docs/android branch March 29, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants