Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a ')' character in the documentation #16515

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

duanqn
Copy link
Contributor

@duanqn duanqn commented Mar 3, 2021

Describe the pull request

  • What does your PR fix?
    This PR removes a ')' character that should not be there. It also decreases the repo size by 1 byte.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    N/A - documentation change
  • Does your PR follow the maintainer guide?
    Yes

@JonLiu1993 JonLiu1993 added the category:documentation To resolve the issue, documentation will need to be updated label Mar 4, 2021
@JackBoosY
Copy link
Contributor

Please download this diff file and apply it, then commit the changes.

@duanqn
Copy link
Contributor Author

duanqn commented Mar 5, 2021

Please download this diff file and apply it, then commit the changes.

@JackBoosY That patch would completely revert my change. Why would vcpkg enforce the extra ')' ?

@duanqn
Copy link
Contributor Author

duanqn commented Mar 5, 2021

Also I don't understand why this triggers format-manifest. I only touched a Markdown file.

@JackBoosY
Copy link
Contributor

@duanqn Our documents are generated automaticlly.

@ghost
Copy link

ghost commented Mar 5, 2021

CLA assistant check
All CLA requirements met.

@JackBoosY
Copy link
Contributor

@duanqn Can you please re-sign CLA?

Thanks.

@duanqn
Copy link
Contributor Author

duanqn commented Mar 5, 2021

I've signed the CLA, thanks!

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 5, 2021
@ras0219-msft
Copy link
Contributor

This LGTM and is ready to merge, however I'll seek to merge several low level infra PRs at the same time to minimize the amount of total-world rebuilds required.

Thanks for the PR!

@JonLiu1993
Copy link
Member

@vicroms ,This pr is ready to merge

@BillyONeal BillyONeal merged commit 5220830 into microsoft:master Apr 29, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution!

@duanqn duanqn deleted the duanqn/fix-doc branch June 22, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants