Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg_*_cmake] remove deprecation message #16480

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Mar 1, 2021

to be replaced by a note in the maintainer-guide
this allows existing ports to build without warnings, so as to avoid warning people unnecessarily,
while still making sure people update when they update ports.

Fixes #16463

to be replaced by a note in the maintainer-guide
this allows existing ports to build without warnings, so as to avoid warning people unnecessarily,
while still making sure people update when they update ports.
@strega-nil strega-nil marked this pull request as ready for review March 1, 2021 19:41
@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. labels Mar 2, 2021
@strega-nil
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once rescoped to just removing the deprecation message

@ras0219
Copy link
Contributor

ras0219 commented Mar 2, 2021

Additionally, if just the maintainer guide changes are reverted, this LGTM as a hotfix that should be applied bypassing CI.

@strega-nil strega-nil merged commit c47216a into microsoft:master Mar 3, 2021
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Mar 3, 2021
[vcpkg_*_cmake] remove deprecation message (microsoft#16480)
@strega-nil strega-nil deleted the remove-deprecation-message branch June 30, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[scripts-audit] Rollup PR 2021-02-26 - cmake scripts not found #16440
3 participants