Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline] Fix baseline regression #15933

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

JackBoosY
Copy link
Contributor

#15015 update seal to 3.6.1, but forgot to update the version record.

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. labels Jan 29, 2021
@JackBoosY
Copy link
Contributor Author

@dan-shaw @BillyONeal Can you please merge this PR quickly?

Thanks.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 29, 2021
@BillyONeal
Copy link
Member

This explains why PRbuild didn't catch it:

image

It's a shame we don't have the ability to require a retest after some timeout (like a week)

@JackBoosY
Copy link
Contributor Author

@BillyONeal We may have a robot to handle this automatically.

@BillyONeal
Copy link
Member

@dan-shaw Since everything is on the floor I'm merging this; please note the above about merging things from almost 2 months ago without retesting

@BillyONeal BillyONeal merged commit c5bffbd into microsoft:master Jan 29, 2021
@JackBoosY JackBoosY deleted the dev/jack/15015 branch January 29, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants