[fontconfig] Avoid error on cross-compile building the fontconfig cache #15869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neumann-A
reviewed
Jan 25, 2021
| @@ -87,7 +87,7 @@ file(INSTALL "${SOURCE_PATH}/COPYING" DESTINATION "${CURRENT_PACKAGES_DIR}/share | |||
|
|
|||
|
|
|||
| ## Build the fontconfig cache | |||
| if(NOT VCPKG_TARGET_IS_WINDOWS) | |||
| if(NOT VCPKG_TARGET_IS_WINDOWS AND NOT CMAKE_CROSSCOMPILING) | |||
There was a problem hiding this comment.
unless you are explicitly setting CMAKE_CROSSCOMPILING in the triplet this variable will not be set. #15424 has a different name for that variable or not? VCPKG_CROSSCOMPILING?
|
Pinging @past-due for response. Is work still being done for this PR? |
|
@JackBoosY I have not had a chance to re-check this PR, and (if memory serves) I believe a better solution might be possible now with host triplet dependencies. I'll close this. |
This was referenced May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix fontconfig cross-compile by not attempting to execute the non-native architecture
fc-cachetool.Avoid
fontconfigbuild failure on cross-compile.Impacts cross-compilation triplets (ex.
arm64-osx).