[vcpkg] Rename port_versions to versions
#15784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
force-pushed
the
port_versions-bikeshedding
branch
3 times, most recently
from
e7eb104 to
42e0708
Compare
|
Only review the second commit, the first one is literally just a rename of |
BillyONeal
approved these changes
Jan 21, 2021
| @@ -319,9 +319,9 @@ Although the concept of package versions has always been present in vcpkg, the c | |||
|
|
|||
| With the introduction of versioning constraints, it is now possible that a package depends on a port version that does not match the one available locally. This raises a problem as vcpkg needs to know how to acquire the port files for the requested version. | |||
|
|
|||
| To solve this problem, a new set of metadata needs to be introduced. This specification proposes a that a new “port_versions” folder is added as part of a registry. In the main vcpkg registry, this means a new root level port_versions directory. | |||
| To solve this problem, a new set of metadata needs to be introduced. This specification proposes a that a new "versions" folder is added as part of a registry. In the main vcpkg registry, this means a new root level versions directory. | |||
There was a problem hiding this comment.
directory, not folder. (Sorry, I know you didn't edit, but still)
There was a problem hiding this comment.
prolly not gonna make that change since I'm just doing the boring rename thing.
There was a problem hiding this comment.
Only worry about it if you need to spin this again. (I view this comment as no different than you asking me to sort cmake vars in the vcpkg_minimum_required PR :) )
strega-nil
force-pushed
the
port_versions-bikeshedding
branch
2 times, most recently
from
d355de4 to
9f300b1
Compare
vicroms
approved these changes
Jan 21, 2021
JackBoosY
added
category:vcpkg-feature
strega-nil
force-pushed
the
port_versions-bikeshedding
branch
from
9f300b1 to
44d4e36
Compare
|
Thanks @vicroms |
strega-nil
force-pushed
the
port_versions-bikeshedding
branch
from
d1aef5d to
4615477
Compare
strega-nil
force-pushed
the
port_versions-bikeshedding
branch
from
4615477 to
d5c6ad8
Compare
strega-nil
added a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bikeshedding, we have decided upon a different name for the existing
port_versionsdirectory and we want to rename it before people start depending on it.