Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsoncons] Update to v0.160.0 #15761

Closed
wants to merge 2 commits into from
Closed

[jsoncons] Update to v0.160.0 #15761

wants to merge 2 commits into from

Conversation

danielaparker
Copy link
Contributor

Describe the pull request

Update to v0.160.0

  • What does your PR fix?

Fixes #302, #295, #283 and #280

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets are supported. CI baseline has been updated.

Yes

@JackBoosY JackBoosY self-assigned this Jan 20, 2021
@JackBoosY
Copy link
Contributor

Regression when building x64-osx:

[1/108] /Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/include -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/tests -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o -MF tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o.d -o tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o -c /Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/tests/src/JSONTestSuite_tests.cpp
FAILED: tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o 
/Library/Developer/CommandLineTools/usr/bin/c++  -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/include -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/tests -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party -I/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch -fPIC -g -arch x86_64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -MD -MT tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o -MF tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o.d -o tests/CMakeFiles/unit_tests.dir/src/JSONTestSuite_tests.cpp.o -c /Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/tests/src/JSONTestSuite_tests.cpp
In file included from /Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/tests/src/JSONTestSuite_tests.cpp:4:
/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch/catch.hpp:509:63: error: expected ';' at end of declaration list
        SourceLineInfo( char const* _file, std::size_t _line ) noexcept
                                                              ^
/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch/catch.hpp:516:43: error: expected ';' at end of declaration list
        SourceLineInfo( SourceLineInfo&& )              noexcept = default;
                                          ^
/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch/catch.hpp:517:56: error: expected ';' at end of declaration list
        SourceLineInfo& operator = ( SourceLineInfo&& ) noexcept = default;
                                                       ^
/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch/catch.hpp:519:27: error: expected ';' at end of declaration list
        bool empty() const noexcept { return file[0] == '\0'; }
                          ^
/Users/vagrant/Data/buildtrees/jsoncons/src/bf6c7a31c4-4b2cd281a1.clean/third_party/catch/catch.hpp:521:62: error: expected ';' at end of declaration list
        bool operator < ( SourceLineInfo const& other ) const noexcept;
                                                             ^
...

failure log attached.

@JackBoosY JackBoosY added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jan 20, 2021
@danielaparker
Copy link
Contributor Author

Thanks for the feedback. It looks like it's running without a c++11 configuration. I'm going to close this pull request and do it over again with some changes to the build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[poco] Not automatically copy pcre.dll in debug mode
2 participants