Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmariadb] Fix compiling on ARM64 #15699

Merged
merged 1 commit into from
Jan 20, 2021
Merged

[libmariadb] Fix compiling on ARM64 #15699

merged 1 commit into from
Jan 20, 2021

Conversation

kotori2
Copy link
Contributor

@kotori2 kotori2 commented Jan 16, 2021

Describe the pull request

@ghost
Copy link

ghost commented Jan 16, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 18, 2021
NancyLi1013
NancyLi1013 reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update port-version in CONTROL and baseline.json files.

@kotori2 kotori2 force-pushed the master branch 2 times, most recently from 7eb6b9f to 9b51906 Compare January 18, 2021 07:48
@kotori2
Copy link
Contributor Author

kotori2 commented Jan 18, 2021

Fixed as suggested.

I'm also wondering how you get git-tree value.

By ./vcpkg x-add-version libmariadb --overwrite-version. But I think I did that wrong before.

@kotori2 kotori2 requested a review from NancyLi1013 January 19, 2021 04:38
@NancyLi1013
Copy link
Contributor

Have you tested these triplets on your machine? @kotori2

Since all triplets for this port was skipped in ci.baseline.txt, I'm not sure if it can build successfully.

@NancyLi1013 NancyLi1013 changed the title Fix libmariadb compiling on ARM64 [libmariadb] Fix compiling on ARM64 Jan 19, 2021
@kotori2
Copy link
Contributor Author

kotori2 commented Jan 19, 2021

Yes, I tested on x64-Windows and arm64-Windows. I think that's enough for this change set.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 19, 2021
@ras0219-msft ras0219-msft merged commit b41a46f into microsoft:master Jan 20, 2021
@ras0219-msft
Copy link
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libmariadb:arm64-windows] build failure
4 participants
@kotori2 @NancyLi1013 @ras0219-msft @JackBoosY