[pagmo2] Add new port #15682
Merged
[pagmo2] Add new port #15682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
added
the
category:new-port
NancyLi1013
suggested changes
Jan 18, 2021
|
Hi @dmillard Thanks for your PR. Have you tested the feature in this PR? |
|
Hi @NancyLi1013, thanks for your reply! Yes, I've tested my branch using an example from the pagmo docs with and without the nlopt option on Linux and Windows. |
NancyLi1013
approved these changes
Jan 19, 2021
NancyLi1013
added
info:reviewed
|
LGTM now, thanks for your PR @dmillard. |
dan-shaw
reviewed
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fixes #13244
I've tested
x64-linux,x86-windows,x64-windows,x64-windows-static, andx64-windows-static-md.Yes.
Previous PR here: #13339, which required a patch that's no longer necessary in Pagmo 2.16.1. Please also see: esa/pagmo2#446