[google-cloud-cpp] update to v1.23.0 #15669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OS/X failure seems unrelated, but happy to be proven wrong. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219
approved these changes
Jan 16, 2021
JackBoosY
added
the
category:port-update
JonLiu1993
approved these changes
Jan 18, 2021
vicroms
requested changes
Jan 18, 2021
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "google-cloud-cpp", | |||
| "version-string": "1.22.0", | |||
| "version-string": "1.23.0", | |||
There was a problem hiding this comment.
Suggested change
| "version-string": "1.23.0", | |
| "version-semver": "1.23.0", |
From what I've seen in their GitHub, this library uses SemVer consistently.
There was a problem hiding this comment.
We do not follow semver, this is documented in each our our libraries:
"Please note that the Google Cloud C++ client libraries do not follow Semantic Versioning."
Furthermore, we strive for API (and not ABI) compatibility, and we do break the API without increasing the major version number, e.g.:
https://github.com/googleapis/google-cloud-cpp/blob/master/CHANGELOG.md#v1210---2020-12
There was a problem hiding this comment.
I see, thanks for the clarification! In this case then version-string is correct 👍
vicroms
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
google-cloud-cppto the latest release (v1.23.0)N/A
No change.
Yes.