[podofo] Fix feature crypto #15666
Merged
[podofo] Fix feature crypto #15666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2021 01:38
JackBoosY
added
category:port-bug
|
Hi @DietmarSchulz, can you test this PR? Thanks. |
PhoebeHui
approved these changes
Jan 15, 2021
PhoebeHui
added
the
requires:all-feature-testing
|
Hi Jack·Boos·Yu,
Thank you for your fast response!
I still get a crash in my application because PODOFO_HAVE_OPENSSL was not set during compile of the podofo library after update.
PdfEncrypt* PdfEncrypt::CreatePdfEncrypt( const PdfObject* )
{
PODOFO_RAISE_ERROR_INFO( ePdfError_NotCompiled, "PdfEncrypt::CreatePdfEncrypt: Encryption support was disabled during compile time" );
return NULL;
}
For update I did:
git pull
vcpk remove podofo:x64-windows
Then I deleted the buildtree of podofo the binary cache 81 and did:
vcpkg install podofo:x64-windows
Regards
Dietmar
Von: Jack·Boos·Yu <[email protected]>
Gesendet: Freitag, 15. Januar 2021 10:41
An: microsoft/vcpkg <[email protected]>
Cc: DietmarSchulz <[email protected]>; Mention <[email protected]>
Betreff: Re: [microsoft/vcpkg] [podofo] Fix feature crypto (#15666)
Hi @DietmarSchulz <https://github.com/DietmarSchulz> , can you test this PR?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#15666 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASMLXDBAP6CMXM34WW2OXCTS2AETBANCNFSM4WDZFDGQ> . <https://github.com/notifications/beacon/ASMLXDGIHXHJOE5H6KWVN6TS2AETBA5CNFSM4WDZFDG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFVMKUFY.gif>
|
|
I see the PR #15666 changes are not committed. How can I test them? |
|
Tried it with you branch vcpkg-dev-jack-15663 and it works! Thank you very much! |
|
Thanks Jack! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 20, 2021
[podofo] Fix feature crypto (microsoft#15666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since openssl generates
libsslandlibcryptoin vcpkg at the same time, change the method of finding crypto to the method in vcpkg.Fixes #15663.