Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Add CI check for version files and update maintainer's guideline #15655

Merged
merged 10 commits into from
Jan 15, 2021

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Jan 14, 2021

Enables CI checks for version files and updates maintainer guidelines.

@vicroms vicroms requested a review from dan-shaw January 15, 2021 00:13
@vicroms
Copy link
Member Author

vicroms commented Jan 15, 2021

Pinging @dan-shaw

This affects the submission process and after this has been merged we will probably need to rerun CI on some previously reviewed PRs.

Also, even though it is a bit expensive, we may also want to enable the --verify-git-trees flag.
It runs extra checks that protects from users declaring a version in the file and declaring a git tree that checks out a completely different one.

With --verify-git-trees: ~3m 30s
Without --verify-git-trees: ~1s

@JackBoosY JackBoosY self-assigned this Jan 15, 2021
@JackBoosY JackBoosY added category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. labels Jan 15, 2021
@vicroms vicroms changed the title Add CI check for version files and update docs [vcpkg] Add CI check for version files and update maintainer's guideline Jan 15, 2021
@dan-shaw
Copy link
Contributor

LGTM. I will pause merging any PRs that will delay this PR.

@PhoebeHui @JackBoosY @NancyLi1013 @JonLiu1993 After this PR is merged, we will need to make sure all PRs that update the CONTROL file also update the respective baseline files for versioning.

@vicroms vicroms merged commit f649f9a into microsoft:master Jan 15, 2021
@PhoebeHui
Copy link
Contributor

@dan-shaw @vicroms, we will check the version and rerun all the PRs, thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants