[vcpkg] Change version field in baseline.json
#15633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicroms
requested review from
ras0219-msft,
strega-nil and
BillyONeal
and removed request for
ras0219-msft
strega-nil
approved these changes
Jan 14, 2021
BillyONeal
approved these changes
Jan 14, 2021
JackBoosY
added
category:vcpkg-feature
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Change version field in `baseline.json` * Change name from `version-tag` to `baseline` * [vcpkg] x-history serializes version scheme * Update e2e tests * Update baseline e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the versioning field in
baseline.jsonto a name that does not match that of a version scheme declaration (version-tag, still bikeshedding this name).Also omnibussing a change to restore the ability for
x-add-versionto write versioning schemes into the version files for two reasons:--versionsfeature flag into the open with PR [vcpkg] Add parse checking for version fields and enable non-string versions outside 'versions' flag #15580.