Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete linux from fail port from tomlplusplus #15609

Merged
merged 4 commits into from
Jan 17, 2021
Merged

delete linux from fail port from tomlplusplus #15609

merged 4 commits into from
Jan 17, 2021

Conversation

marshevms
Copy link
Contributor

  • What does your PR fix?
    Build on GNU/Linux
    If you can confirm success build on other platforms I also can delete them from cmake file

@marshevms marshevms force-pushed the delete_linux_from_fail_port branch from c441239 to e152f9b Compare January 12, 2021 16:59
@ghost
Copy link

ghost commented Jan 12, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 13, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 14, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for our PR. @marshevms.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw dan-shaw merged commit 0c94afc into microsoft:master Jan 17, 2021
@traversaro
Copy link
Contributor

I think the other platforms were disabled mostly due to the right version of meson not available in the CI machine. If anyone is interested, probably just enabling them and check if CI is able to run correctly I guess is probably enough.

@NancyLi1013
Copy link
Contributor

@traversaro

Thanks for your kindly reminder. We will check this later.

@NancyLi1013
Copy link
Contributor

Confirmed tomlplusplus can work on osx platform now. I can build it without any problems on my local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marshevms @NancyLi1013 @traversaro @JackBoosY @dan-shaw