-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cppgraphqlgen] Fix --head for new branch/option #15549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also bump version in CONTROL file?
Hi @wravery Thanks for your PR. Have you tested if I tried to install on my machine, it posted the error like this:
|
It does require that you install |
Thanks for your response @wravery. Have installed successfully now after install |
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Since I'm not actually changing the commit, I just added |
LGTM now, thanks. |
Describe the pull request
I'm not ready to update
cppgraphqlgen
to the v3.4.1 release yet because it depends on a change inpegtl
which hasn't been released as v3.1.1 yet. However, installing both of those with--head
should work, and right now it doesn't work forcppgraphqlgen
. I renamed the default branch frommaster
tomain
, and there's a newGRAPHQL_UPDATE_VERSION=OFF
CMake
option which the portfile needs to specify. Using that option with a prior commit will just be ignored.No, as far as I know the CI baselines should all work.
Yes.