-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flashlight-cpu] New port #15514
[flashlight-cpu] New port #15514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also bump version for flashlight-cuda
in vcpkg.json?
Add port-version: 1
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Co-authored-by: NancyLi1013 <[email protected]>
Bump @JackBoosY @NancyLi1013 :) |
Co-authored-by: NancyLi1013 <[email protected]>
Have you tested these features? Can they work fine? |
@NancyLi1013 — I've tested the ports on |
LGTM now, thanks for your PR @jacobkahn. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Adds a port for the flashlight CPU backend.
Note that only one of the flashlight backends (
flashlight-cpu
orflashlight-cuda
) can be installed since the two share library bits and headers. Checks have been added toflashlight-cuda
. This might be relaxed down the line/we may reorganize the structure of the flashlight backends.cc @padentomasello, @xuqiantong, @vineelpratap, @tlikhomanenko, @avidov, @syhw, @andresy
x64-linux
-- same asflashlight-cuda
Yes