Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flashlight-cpu] New port #15514

Merged
merged 13 commits into from
Jan 17, 2021
Merged

[flashlight-cpu] New port #15514

merged 13 commits into from
Jan 17, 2021

Conversation

jacobkahn
Copy link
Contributor

Adds a port for the flashlight CPU backend.

Note that only one of the flashlight backends (flashlight-cpu or flashlight-cuda) can be installed since the two share library bits and headers. Checks have been added to flashlight-cuda. This might be relaxed down the line/we may reorganize the structure of the flashlight backends.

cc @padentomasello, @xuqiantong, @vineelpratap, @tlikhomanenko, @avidov, @syhw, @andresy

  • Which triplets are supported/not supported? Have you updated the CI baseline?

x64-linux -- same as flashlight-cuda

Yes

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 8, 2021
Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also bump version for flashlight-cuda in vcpkg.json?

Add port-version: 1

@jacobkahn jacobkahn requested a review from NancyLi1013 January 9, 2021 18:01
@jacobkahn
Copy link
Contributor Author

Bump @JackBoosY @NancyLi1013 :)

@jacobkahn jacobkahn requested a review from NancyLi1013 January 14, 2021 02:53
@NancyLi1013
Copy link
Contributor

Have you tested these features? Can they work fine?

@jacobkahn
Copy link
Contributor Author

@NancyLi1013 — I've tested the ports on x64-linux, and everything works.

@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @jacobkahn.

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 15, 2021
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw dan-shaw merged commit 58bf44e into microsoft:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants