[boost-asio] Fix duplicate symbols of asio::dummy_return<void> #15513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@cedral Thanks for this PR! Thanks. |
JackBoosY
suggested changes
Jan 8, 2021
JackBoosY
added
category:port-bug
JackBoosY
approved these changes
Jan 8, 2021
|
Thanks I'll take note of the Port-Version setting for future reference. I am not sure if I am supposed to close this or not so I will leave that to you. |
|
LGTM. |
PhoebeHui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The fix already exists (chriskohlhoff/asio#584), but it hasn't been merged yet. Would it be possible to apply a patch to fix this for version 1.75.0? It is very low impact https://gist.github.com/jprochazk/ecb261bb99489a3d0fef03a4ae27c064
What does your PR fix? Fixes #
Build any of the asio coroutine examples with latest MSVC and Boost 1.75.0. It should compile, but linking will fail:
error LNK2005: "void __cdecl boost::asio::dummy_return<void>(void)" (??$dummy_return@X@asio@boost@@YAXXZ) already definedWhich triplets are supported/not supported? Have you updated the CI baseline?
-windows- is affected, no I haven't.
Does your PR follow the maintainer guide?
I haven't read it.