[vcpkg] Allow to use Nuget's cache for Nuget binary caching sources (fix #15169) #15512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning was ```shell ../src/vcpkg/commands.porthistory.cpp:55:14: error: unused function 'is_date' [-Werror,-Wunused-function] ```
As the name suggests, this environment variable allow tu use Nuget cache for Nuget binary caching sources.
JackBoosY
added
the
category:vcpkg-feature
|
cc @ras0219 for review this PR. |
|
Hi @ras0219 ! Any news/feedback on the pull request? 🙂 |
ras0219
suggested changes
Jan 22, 2021
There was a problem hiding this comment.
Sorry for the long feedback loop!
This LGTM, though the new environment variable should be added:
- to
docs/users/config-environment.md(cross-linked with binarycaching.md) - to
docs/users/binarycaching.md(cross-linked withconfig-environment.md) - to
help_topic_binary_caching()inbinarycaching.cpp
Once docs are added, this should be merged! Thanks again for the great feature work :)
JackBoosY
approved these changes
Jan 25, 2021
JackBoosY
added
info:reviewed
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
microsoft#15169) (microsoft#15512) * Fix warning on clang version 10.0.0-4ubuntu1 The warning was ```shell ../src/vcpkg/commands.porthistory.cpp:55:14: error: unused function 'is_date' [-Werror,-Wunused-function] ``` * Add environment variable VCPKG_USE_NUGET_CACHE As the name suggests, this environment variable allow tu use Nuget cache for Nuget binary caching sources. * Document NuGet's Cache environment variable
|
@JackBoosY any chance a command-line option could be added to avoid having to set the ENV variable? Like --x-use-nuget-cache? |
You can open an issue with this question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
VCPKG_BINARY_SOURCES#15169I also fixed a warning on
Fix warning on clang version 10.0.0-4ubuntu1so that I could compiletoolsrc(the functionis_datewas not used anymore).I should probably add documentation, but I wanted feedback before writing the doc. I fixed the issue I raise in #15169 by introducing an environment variable
VCPKG_USE_NUGET_CACHE. This is the simplest solution I could think of, and it has the advantage of requiring a very small changeset/pull request.I'm looking forward for your feedback. 🙂
Which triplets are supported/not supported? Have you updated the CI baseline? The same. No.
Does your PR follow the maintainer guide? Yes.